Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GitHub release from each version tag #55

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

jorhett
Copy link

@jorhett jorhett commented May 14, 2024

This will add a GitHub release for any version tag pushed to the repo. This was requested by @bastelfreak at https://puppetcommunity.slack.com/archives/C0W1Y5VL0/p1715636371866939

The gh-release action used here is both

  • the most popular action that implements the release functionality
  • the one I've had the most positive experiences with personally

Obviously this is a basic demonstration which could be further tuned to improve the release description, as per https://github.com/marketplace/actions/gh-release#-customizing

@bastelfreak
Copy link
Member

for our containers @rwaffen recently worked on a workflow to generate github releases:

https://github.com/voxpupuli/crafty/blob/main/.github/workflows/release.yml + voxpupuli/container-puppetserver@fc47fa9 and I think we should try to use the same approach for all of our projects. Than it probably makes sense to move this to it's own repo.

@jorhett jorhett force-pushed the add-github-release branch from d3a8061 to 267424b Compare May 14, 2024 07:34
---
name: GitHub Release

on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use on in a reusable action. With what's here I doubt there's a point in making a reusable action out of this: your dependency already does that (except checkout). Modulesync may be a better place to do this.

@rwaffen
Copy link
Member

rwaffen commented May 14, 2024

didn't saw @bastelfreak comment (sorry for confugisn emails about my comments), yes, i would recommend using my approach, instead of depending on a third party workflow. i have a pr/branch prepared for this on my local 😅

@rwaffen
Copy link
Member

rwaffen commented May 14, 2024

as tim said, i did something and now i found it again and pushed all changes. it is the code from crafty, put together as its own gha.

https://github.com/voxpupuli/gha-create-a-github-release

i think we need only propper tags/branches on the gha and then its ready to use

@jorhett
Copy link
Author

jorhett commented May 14, 2024

I'm all for whatever works. This was my quick punt to show @bastelfreak how easy it was, as he requested.

@rwaffen
Copy link
Member

rwaffen commented May 15, 2024

he played us... me and @bastelfreak had the same talk :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants